Geometry Boost List: Re: [geometry] io - WKB

Subject: Re: [geometry] io - WKB
From: Mateusz Loskot (mateusz_at_[hidden])
Date: 2013-08-29 19:25:02

On 28 August 2013 20:52, Mats Taraldsvik <mats.taraldsvik_at_[hidden]> wrote:
> On 08/28/2013 05:37 PM, Barend Gehrels wrote:
> I have attached three patches, created from git using this recipe
> http://codeprairie.net/blogs/chrisortman/archive/2008/01/14/creating-subversion-patches-with-git.aspx
>
> It would be great if you could review them.

Mats,

I updated your patches and submitted as ticket to Boost Trac

https://svn.boost.org/trac/boost/ticket/9066

where it has more convenient form for review:

https://svn.boost.org/trac/boost/attachment/ticket/9066/Mats-Taraldsvik-MultiPoint-WKB.patch

What I've done is:

- translated your Git patches into SVN format
- Applied your patches: patch  -p0 -i 000[1-3].patch
- Added Jamfile.v2 files to enable building and running tests
- svn diff > Mats-Taraldsvik-MultiPoint-WKB.patch

It looks good, I haven't spotted any issues.
Also, the read_wkb.cpp tests run and pass for me (Linux 64-bit, GCC 4.8.1).

If no objections arrive, I can submit your patch to SVN trunk.

Thanks!

Best regards,
-- 
Mateusz  Loskot, http://mateusz.loskot.net
"Participation in this whole process is a form of torture" ~~ Szalony