Geometry Boost List: Re: [geometry] compilation failure with wkb - Polygon

Subject: Re: [geometry] compilation failure with wkb - Polygon
From: Mateusz Loskot (mateusz_at_[hidden])
Date: 2013-10-24 16:30:26

On 24 October 2013 21:23, Mats Taraldsvik <mats.taraldsvik_at_[hidden]> wrote:
> On 10/24/2013 06:04 PM, Mateusz Loskot wrote:
>> On 22 October 2013 19:18, Mats Taraldsvik <mats.taraldsvik_at_[hidden]> wrote:
>>>
>>> Hi Barend and Mateusz,
>>>
>>> I have started on multipolygon wkb support as well. However, I'm still
>>> struggling with compilation errors when testing ordinary (not multi)
>>> types.
>>>
>>> The multipoint ticket contains a LineString test, commented out, which
>>> does
>>> not compile.
>>>
>>> Today I tried to add a Polygon test, but it does not compile either. Are
>>> you
>>> able to help me with this, as I have been stuck for a couple of hours...?
>>>
>>> (I've attached the compilation errors)
>>>
>>> This is the Polygon test, add it to extensions/test/gis/io/wkb
>>>
>>>
>>>      typedef bg::model::polygon<point_type> polygon_type;
>>>
>>>      //
>>>      // Polygon
>>>      //
>>>
>>>      test_geometry_equals<polygon_type, true>(
>>>
>>> "010300000001000000050000000000000000005940000000000000694000000000000069400000000000006940000000000000694000000000000079400000000000005940000000000000794000000000000059400000000000006940",
>>>      "POLYGON((100 200, 200 200, 200 400, 100 400, 100 200))"
>>>      );
>>
>> Hi Mats,
>>
>> The missing strategies header I added yesterday also solves the
>> polygon compilation,
>> I've just added new (incremental) version of the patch:
>>
>> Mats-Taraldsvik-MultiPoint-WKB-linestring-test-fixed-polygon-added.patch
>>
>> with the polygon test added.
>>
>> It all compiles for me using GCC 4.8 and clang 3.3.
>
>
>
>>
>> To summary, I think all the compilation problems have been solved.
>> Apology it took me so long for check it.
>
>
>
> No worries, thank you for helping me with this, I sometimes struggle with
> deciphering the compilation errors... :)

No problem, I'm still mastering fast backscrolling of my terminal :)

> I will try to add some more tests for linestring and polygon, and then
> proceed with WKB multi-support. :)

Great, let me know if you need help.

Later, I'm going to quickly compare the WKT tests with what we've got in WKB,
so both tests (test cases, used geometries, testing conditions,
testing utilities)
look and feel similar way.

Best regards,
-- 
Mateusz  Loskot, http://mateusz.loskot.net