Subject: Re: [geometry] distance contribution merge request
From: Menelaos Karavelas (menelaos.karavelas_at_[hidden])
Date: 2014-05-16 07:28:37
Hi again, and especially Samuel.
On 16/05/2014 02:12 ??, Menelaos Karavelas wrote:
> Hi all.
> On 15/05/2014 12:48 ??, Bruno Lalande wrote:
>> Hi Samuel,
>> Before I go further into this, there are 2 things I'd like you to
>> - Could you please use the transform_variant and compress_variant
>> helper functions I've put in place instead of the heavy MPL
>> manipulations you're doing? I think that's exactly what you were
>> trying to do (and I agree it's the right thing to do). You have an
>> example in the perimeter algorithm.
>> - Could you detach the handling of default strategies into an actual
>> resolve_strategy step? You can take examples from various algos, it
>> basically uses an instance of default_strategy class in the
>> no-strategy free function, which is then passed along to
>> resolve_strategy since it can only be resolved when variants are
>> I suspect those 2 things will make the code clearer.
> FYI, the distance code file structure has changed a bit: the free
> function definition is now in
> and the implementation details are all collected in
> The main file (boost/geometry/algorithms/distance.hpp) now contains
> includes to the above two files.
> The code is not merged yet into BG develop, but you may find it in:
The changes have been merged into develop (thanks Adam).
> Best regards,
> - m.
>> Geometry mailing list
Geometry list run by mateusz at loskot.net