Re: [Threads-devel] PATCH: Disable native_handle tests on win32 to make all unit-tests pass

Subject: Re: [Threads-devel] PATCH: Disable native_handle tests on win32 to make all unit-tests pass
From: Fredrik Orderud (forderud_at_[hidden])
Date: 2013-01-06 10:54:44

On Sat, Jan 5, 2013 at 2:37 PM, Vicente J. Botet Escriba <
vicente.botet_at_[hidden]> wrote:

> Le 05/01/13 11:18, Fredrik Orderud a écrit :
>
>  Currently, 10 of the boost thread unit-tests on trunk fail when building
>> with msvc-11 (Microsoft Visual Studio 2012). All of the failing tests are
>> due to native_handle() methods not being implemented on win32 [1]. The
>> boost thread synchronization doc states that native_handle() is an optional
>> method that is not available on all platforms [2]. Therefore, one can argue
>> that the lack of native_handle() must not necessarily be treated as an
>> error in the tests. I've therefore attached a patch that disables
>> native_handle tests on win32, so that all unit-tests pass.
>>
>> The reason for my request is that it would be very nice with a error-free
>> unit-test baseline prior to implementing changes to the thread library.
>>
>>
>>  Hi,
>
> I have found an alternative that consists in not running the test when
> threadapi is win32
>
> Please could you check the following patch?
>
> I would commit it if it works for you.
>

Thank you Vicente. I hereby confirm that as of  r82375, all thread
unit-tests succeed on my computer with msvc-11.

Regards,
Fredrik