Re: array formal review

From: Nicolai Josuttis (nico_at_[hidden])
Date: 2000-07-02 12:29:24

Thank you Jeremy for this summary.
I'll try to make these changes ASAP.

 Nico

--- In boost_at_[hidden], jsiek_at_l... wrote:
> 
> The array library by Nicolai Josuttis is accepted into boost.  I'd
> like to thank Nicolai Josuttis for this contribution, as well as
> everyone who submitted comments.
> 
> The following are the highlights of the changes requested in the
comments. 
> 
> 1. should include boost/config.hpp instead of re-doing std::size_t
workaround
> 2. use std::equal, std::mismatch, std::lexicographical to implement
!=, etc.
>    and std::swap_ranges to implement swap (unless decide to drop
swap)
> 3. data() function returning pointer
> 4. size(), empty(), max_size() static, with empty() returning false
> 5. Provide access to the size at compile time, through an enum or
>    static const member named static_size.
> 6. Document the rationale for the public data member, etc.
> 7. assign() functions as in std::vector and a templated operator=
> 8. rangecheck() should be const, and possibly private
> 
> We look forward to seeing the final version of array in boost!
> 
> Cheers,
> 
> Jeremy
> 
> 
>
----------------------------------------------------------------------
>  Jeremy Siek                        www:
http://www.lsc.nd.edu/~jsiek/
>  Ph.D. Candidate                  email: jsiek_at_l...
>  Univ. of Notre Dame         cell phone: [phone]   
>
----------------------------------------------------------------------