Re: [boost] Boost inspection notification (2006-09-28/RC_1_34_0) *X*

From: Joaquín Mª López Muñoz (joaquin_at_[hidden])
Date: 2006-09-29 02:59:52

Roland Schwarz ha escrito:

> Rene Rivera wrote:
> > Boost Inspection Report
> > Run Date: 16:03:07 UTC, Thursday 28 September 2006
> >
> > An inspection program <http://www.boost.org/tools/inspect/index.html>
> > checks each file in the current Boost CVS for various problems,
> > generating this as output. Problems detected include tabs in files,
> > missing copyrights, broken URL's, and similar misdemeanors.
> [ ... ]
> >   38 usages of unnamed namespaces in headers (including .ipp files)
> [ ... ]
> > |thread|
> >   libs/thread/src/mutex.inl:
> >     *U* unnamed namespace at line 7
> >   libs/thread/src/timeconv.inl:
> >     *U* unnamed namespace at line 7
> >   libs/thread/test/util.inl:
> >     *U* unnamed namespace at line 19
>
> I foolowed the link http://www.boost.org/tools/inspect/index.html
> and then "guidline violations" http://www.boost.org/more/lib_guide.htm
> but was not able to find the guidelines about "usage of unnamed
> namespaces in headers". Also the suspect files are neither *.hpp nor *.ipp.
>

I'm afraid the docs are outdated. Currently, these are the inspected issues:

* copyright notice is present
* crlf_check.hpp"
* Boost license info is included
* links to other parts of Boost are correct, and there are no unlinked files
* filename lengths <=31 and other file and path restrictions by ISO 9660
  lev 3 format
* no tabs are used
* usage of min and max is macro safe
* No unnamed spaces are used in headers

As for the latter, the problem with unnamed spaces in headers is that they
can lead to ODR violations, see for instance:

http://lists.boost.org/Archives/boost/2004/06/67159.php

> Can you please give me a hint, how I should correct this?

If you think your usage of unnamed spaces is actually correct, then
simply have your file contain the following (possibly inside a comment):

boostinspect:nounnamed

to instruct the inspect tool to skip.

HTH

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo