Re: [boost] Inspection report (*C*, *L*)

From: Joel de Guzman (joel_at_[hidden])
Date: 2008-07-02 09:42:31

David Abrahams wrote:
> Hartmut Kaiser wrote:
>> Joel,
>>
>>>> New reports up at:
>>>>     <http://www.idio.com/misc/inspect-release.html>
>>>>     <http://www.idio.com/misc/inspect-trunk.html>
>>> Ok, I have a small problem:
>>>
>>> spirit
>>>
>>> libs/spirit/example/qi/mini_xml_samples/1.xml: *C*, *L*
>>> libs/spirit/example/qi/mini_xml_samples/2.xml: *C*, *L*
>>> libs/spirit/example/qi/mini_xml_samples/3.xml: *C*, *L*
>>>
>>> These are sample files for the very-minimal tiny-xml sample.
>>> The parser is very simple and does not parse comments. Adding
>>> rules for comments, just to satisfy the inspection report,
>>> does not seem to be justified as it will add noise to the
>>> example. Here's an example:
>>>
>>>      <foo>
>>>          <bar>bar 1</bar>
>>>          <bar>bar 2</bar>
>>>          <bar>bar 3</bar>
>>>      </foo>
>>>
>>> What can I do about this? Do we have some way to inhibit checking
>>> for such /special-case/ files?
>> We could remove the files completely and put the xml snippets as strings
>> into the example. I know this somehow defeats the intent to show how to
>> parse arbitrary simple xml, but hey it's a sample...
> 
> Or you could open the file and skip over the first N lines before
> parsing the XML.

I think I'll just rename it *.toyxml. It's not real xml anyway.

Regards,
-- 
Joel de Guzman
http://www.boostpro.com
http://spirit.sf.net