Re: [boost] regex submission

From: David Abrahams (abrahams_at_[hidden])
Date: 2000-09-23 09:22:58

Hi John,

Some comments on the latest regex submissions:

------
I wonder about this. Shouldn't this maybe be #ifdef _WIN32?

#if defined(BOOST_MSVC) || defined(__BORLANDC__)
typedef bool (__cdecl *GrepCallback)(const RegEx& expression);
typedef bool (__cdecl *GrepFileCallback)(const char* file, const RegEx&
expression);
typedef bool (__cdecl *FindFilesCallback)(const char* file);
#else
typedef bool (*GrepCallback)(const RegEx& expression);
typedef bool (*GrepFileCallback)(const char* file, const RegEx& expression);
typedef bool (*FindFilesCallback)(const char* file);
#endif

------
Also, you use lots of ALL_UPPERCASE names for enum values. These really
should be reserved for preprocessor macros.

-Dave