Re: [boost] py_cpp Review

From: David Abrahams (abrahams_at_[hidden])
Date: 2000-10-11 09:26:26

----- Original Message -----
From: "Gary Powell" <Gary.Powell_at_[hidden]>

> Ok, this is my last comment...
>
>   in errors.h, the error class "ErrorAlreadySet" shouldn't this class be
> derived from "std::runtime_error" ?

Why do you think so?

> and the in expect_non_null, the message
> "from expect_non_null" or some such text, be passed into the constructor
so
> that a call to err::what() has a meaningful if somewhat obscure message?

ErrorAlreadySet means that the Python exception-handling mechanism has
already been invoked to set Python's thread-local idea of the exception type
and value. For standard Python exceptions, the value wraps a Python string,
so the message is already taken care of.

-Dave