Re: Formal review: New Boost.Test Library

From: Gennadiy E. Rozental (rogeeff_at_[hidden])
Date: 2001-12-01 23:03:27

--- In boost_at_y..., "David Abrahams" <david.abrahams_at_r...> wrote:
> 
> Some comments on the documentation:
> 

[snip]

> 
> I could go on; most of what I'm pointing out are understandable 
English
> usage errors and awkwardnesses (is that a word? Even if it is, it's
> awkward!)  I will volunteer to edit a few of the pages; if you can 
find a
> few more strong English speakers to do the same, these issues could 
be
> easily cleaned up.

I realize that documentation definetly need a look of person with 
native or fluent english. I greatly appritiate any help.

> 
> =============
> 
> Hmm, is tiemeout a type or a parameter name? What type is it really?
> 

int 

> 
> =======
> Does execution_monitor install a terminate handler, so that 
problems like
> exceptions thrown during stack unwinding can at least be hinted at?

No. But I will think about it.

> =========
> In test_tools.htm, you mention std::assert(), which (sadly) doesn't 
exist.

Ok

> =========
> BOOST_CHECKPOINT( message ) - to be used to mark a test flow with a 
check
> points. The checkpoint can help to locate a source of a runtime 
exception.
>     Example: test.cpp
>        int test_main( int, char* [] )
>       {
>           BOOST_CHECKPOINT( "Going to throw an exception" );
>           throw "some error";
>           return 0;
>        }
>     Output:
>         Exception in test_main : C string:some_error
>         test.cpp(3) : last checkpoint: Going to throw an exception
> 
> 
> Have you considered supplying BOOST_THROW(...) instead?

What exectly do you mean? 
I have BOOST_CHECK_THROW to check whether or not exception was 
thrown. 

> 
> =========
> 
> -Dave

Thank you,

Gennadiy