Re: [boost] Release run up: Win32 Regression Test updated

From: Giovanni Bajo (giovannibajo_at_[hidden])
Date: 2002-05-07 08:21:44

----- Original Message -----
From: "Beman Dawes" <bdawes_at_[hidden]>
To: <boost_at_[hidden]>; <boost_at_[hidden]>
Sent: Tuesday, May 07, 2002 2:30 PM
Subject: Re: [boost] Release run up: Win32 Regression Test updated

>  >I'm testing that now, I hope to check in the changes shortly, hopefully
> it
>  >will fix both some of the intel and commeau failures.
>
> Thanks.
>
> I tried arithmetic_traits_test.cpp; it is now passing for all Win32
> compilers.  There was one warning from Comeau; see below.

Please, be sure to test Comeau also in Microsoft mode. It's a common usage
pattern for this compiler that Boost should support flawlessly. Also,
looking at Comeau.hpp, I see:

#if (__COMO_VERSION__ <= 4245) || !defined(BOOST_STRICT_CONFIG)
#  if defined(_MSC_VER) && _MSC_VER <= 1300
#     define BOOST_NO_STDC_NAMESPACE
#     define BOOST_NO_ARGUMENT_DEPENDENT_LOOKUP
#     define BOOST_NO_SWPRINTF
#  endif
#endif

This piece of code was probably meant as workarounds when emulating
Microsoft mode. Now, Peter Dimov discovered lately that _MSC_VER is defined
in strict mode too (where e.g. argument dependent lookup obviously work)
with value 1. So I propose:

// Notice that 4.3 BETA #1 still defines version 4245
#if (__COMO_VERSION__ <= 4245) || !defined(BOOST_STRICT_CONFIG)
# if defined(_MSC_VER) && _MSC_VER > 1 && _MSC_VER <= 1300
 ... as above...
# endif

Giovanni Bajo