|
Boost : |
From: John Maddock (john_maddock_at_[hidden])
Date: 2002-07-14 06:12:41
> I've taken the liberty of committing fixes for *some* of boost's
BOOST_MSVC
> checks which weren't checking the version number. I took a somewhat
> conservative route, which also means it's somewhat ham-fisted -- in many
> cases the original test was written with MSVC6 in mind, and I just assumed
> that the same workaround would be needed for MSVC7 but not for later
> compilers. Hopefully, the enclosed list will be enough to prompt authors
> and maintainers to look over the changes and tune them appropriately.
Your patch to stlport.hpp breaks VC6 + STLport 4.5.3 (it now thinks that
long long is supported when it's not). IMO you don't need that patch: the
new config/suffix.hpp should take care of everything.
IMO the patch to conversion_traits.hpp should be removed as well: the MS
specific version of is_convertible has #pragma warning suppression that the
generic version lacks (otherwise either version is equally good).
John Maddock
http://ourworld.compuserve.com/homepages/john_maddock/index.htm
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk