Re: [boost] stlport config patch

From: John Maddock (john_maddock_at_[hidden])
Date: 2002-07-16 05:46:22

> I porpose following patch:
>
> Index: stlport.hpp
> ===================================================================
> RCS file: /cvsroot/boost/boost/boost/config/stdlib/stlport.hpp,v
> retrieving revision 1.13
> diff -r1.13 stlport.hpp
> 90c90
> < #  if defined(__STL_IMPORT_VENDOR_CSTD) ||
> defined(__STL_USE_OWN_NAMESPACE) || defined(_STLP_IMPORT_VENDOR_CSTD) ||
> defined(_STLP_USE_OWN_NAMESPACE)
> ---
> > #  if (defined(__STL_IMPORT_VENDOR_CSTD) ||
> defined(__STL_USE_OWN_NAMESPACE) || defined(_STLP_IMPORT_VENDOR_CSTD) ||
> defined(_STLP_USE_OWN_NAMESPACE)) &&
> !defined(_STLP_DO_IMPORT_CSTD_FUNCTIONS)

It would help if you explained why :-)

I assume that you're assuming that importing C std lib functions into
namespace std is unnecessary if STLport has already done so?

The trouble is, STLport doesn't actually guarantee to import everything - my
experience with regex is that it often leaves one or two symbols out on most
platforms (but different ones in each case).  Since duplicate using
declarations are harmless, I suggest that we leave it as it is - things will
break if we don't :-(

John Maddock
http://ourworld.compuserve.com/homepages/john_maddock/index.htm