[boost] Re: stlport config patch

From: Gennadiy Rozental (rogeeff_at_[hidden])
Date: 2002-07-16 11:07:05

"John Maddock" <john_maddock_at_[hidden]> wrote in message
news:016201c22cb8$498edfe0$a6c4193e_at_1016031671...
> > I porpose following patch:
> >
> > Index: stlport.hpp
> > ===================================================================
> > RCS file: /cvsroot/boost/boost/boost/config/stdlib/stlport.hpp,v
> > retrieving revision 1.13
> > diff -r1.13 stlport.hpp
> > 90c90
> > < #  if defined(__STL_IMPORT_VENDOR_CSTD) ||
> > defined(__STL_USE_OWN_NAMESPACE) || defined(_STLP_IMPORT_VENDOR_CSTD) ||
> > defined(_STLP_USE_OWN_NAMESPACE)
> > ---
> > > #  if (defined(__STL_IMPORT_VENDOR_CSTD) ||
> > defined(__STL_USE_OWN_NAMESPACE) || defined(_STLP_IMPORT_VENDOR_CSTD) ||
> > defined(_STLP_USE_OWN_NAMESPACE)) &&
> > !defined(_STLP_DO_IMPORT_CSTD_FUNCTIONS)
>
> It would help if you explained why :-)
>
> I assume that you're assuming that importing C std lib functions into
> namespace std is unnecessary if STLport has already done so?
>
> The trouble is, STLport doesn't actually guarantee to import everything -
my
> experience with regex is that it often leaves one or two symbols out on
most
> platforms (but different ones in each case).  Since duplicate using
> declarations are harmless, I suggest that we leave it as it is - things
will
> break if we don't :-(

It is not a duplication. Without this patch I have a lot of failures in
every place where we see
namespace std {
using ::whatever;
}
since "whatever" does not belong to global namespace.

>
> John Maddock
> http://ourworld.compuserve.com/homepages/john_maddock/index.htm

Gennadiy.