[boost] Re: [dynamic bitset] Wrong test for MSVC6/7 and dinkumware lib?

From: Gennaro Prota (gennaro_prota_at_[hidden])
Date: 2002-09-30 10:46:14

On Mon, 30 Sep 2002 16:56:38 +0200, Markus Schöpflin
<markus.schoepflin_at_[hidden]> wrote:

>Hello,
>
>the file boost/dynamic_bitset.hpp contains a check for MSVC6/7 and it's 
>STL on line 500. It reads as follows:
>
>#if (defined(_MSC_VER) && (_MSC_VER <= 1300)) || !defined(_CPPLIB_VER) 
>|| (_CPPLIB_VER < 306) // Dinkumware for VC6/7
>
>Shouldn't this read
>
>#if (defined(_MSC_VER) && (_MSC_VER <= 1300)) && (!defined(_CPPLIB_VER) 
>|| (_CPPLIB_VER < 306)) // Dinkumware for VC6/7

I noticed that fact when working on the file. At least the comment is
misleading. However I left the code as is because I have already flood
Jeremy with a lot of changes and he is quite busy at the moment, to
the point that he hasn't even committed the most important ones. That
#if triggers as soon you use VC++6/7, whatever the library is. In
particular with STLport, where the code works anyway however. That's
the reason (the fact that it worked) why I haven't stressed Jeremy
with that too: there are really a lot more important things to fix in
the current code, and I preferred to have his attention on them first.
For instance the implementation of to_block_range is erroneous, as
well as to_string and from_string. There are also errors, my fault but
now corrected too, if your compiler implements two phase name lookup
properly.

To whet your appetite the new files also implement a new manipulator
that allows the extraction of an indefinite number of characters from
an input stream (like for extraction of std::strings). More or less it
will work this way:

   dynamic_bitset<> bs;
   cin >> bs_limit(bsinf) >> bs;

In this case as many '1' and '0' characters as possible are extracted
from cin, regardless of bs.size().

But consider this just as a little preview of something that could be
changed radically (especially the names :-)).

As I said, Jeremy is currently too busy to look at the changes. As
soon as he will be ready and will commit the new files, I'll look at
the problem you point out too.

Genny.