[boost] Re: [dynamic bitset] Wrong test for MSVC6/7 and dinkumware lib?

From: Markus Schöpflin (markus.schoepflin_at_[hidden])
Date: 2002-09-30 10:54:06

Gennaro Prota wrote:
 > On Mon, 30 Sep 2002 16:56:38 +0200, Markus Schöpflin
 > <markus.schoepflin_at_[hidden]> wrote:
 >
 >> Hello,
 >>
 >> the file boost/dynamic_bitset.hpp contains a check for MSVC6/7 and
 >> it's STL on line 500. It reads as follows:
 >>
 >> #if (defined(_MSC_VER) && (_MSC_VER <= 1300)) ||
 >> !defined(_CPPLIB_VER) || (_CPPLIB_VER < 306) // Dinkumware for
 >> VC6/7
 >>
 >> Shouldn't this read
 >>
 >> #if (defined(_MSC_VER) && (_MSC_VER <= 1300)) &&
 >> (!defined(_CPPLIB_VER) || (_CPPLIB_VER < 306)) // Dinkumware for
 >> VC6/7
 >
 > I noticed that fact when working on the file. At least the comment is
 >  misleading. However I left the code as is because I have already
 > flood Jeremy with a lot of changes and he is quite busy at the
 > moment, to the point that he hasn't even committed the most important
 > ones. That #if triggers as soon you use VC++6/7, whatever the library
 > is. In particular with STLport, where the code works anyway however.

[snip]

Hmm, doesn't this code trigger whenever _CPPLIB_VER isn't defined? 
Currently, this is the reason why the tests for dynamic_bitset fail on 
vacpp 5. If you change the macro (and the one in 
detail/dynamic_bitset.hpp), the tests pass.

Markus