[boost] Re: [dynamic bitset] Wrong test for MSVC6/7 and dinkumwarelib?

From: Markus Schöpflin (markus.schoepflin_at_[hidden])
Date: 2002-10-01 02:50:50

Gennaro Prota wrote:
> 
> On Mon, 30 Sep 2002 17:54:06 +0200, Markus Schöpflin
> <markus.schoepflin_at_[hidden]> wrote:
> 
> [snip]
> >Hmm, doesn't this code trigger whenever _CPPLIB_VER isn't defined?
> 
> Yes, that's another sufficient condition.
> 
> >Currently, this is the reason why the tests for dynamic_bitset fail on
> >vacpp 5. If you change the macro (and the one in
> >detail/dynamic_bitset.hpp), the tests pass.
> 
> You are right, of course. I hope to hear soon from Jeremy. I don't
> have write access to the CVS, so I'll fix the file but you won't see
> it in the repository until he will commit it.

Well, if you have a fix and Jeremy gives his ok, I could apply it.

> 
> BTW, your correction isn't correct either: this sorts of "negative
> tests" (test what there isn't, instead of what there is) are always
> dangerous :-)

I don't get this one. Let's analyse the macro as proposed.

#if (defined(_MSC_VER) && (_MSC_VER <= 1300)) // true for MSVC <=7.0
&& (!defined(_CPPLIB_VER) // true if _CPPLIB_VER not defined
   || (_CPPLIB_VER < 306)) // true if _CPPLIB_VER < 306

This means the macro evaluates to true iff the compiler is MSVC <= 7.0
AND the is no dinkumware lib or it's version is less than 306.

Did I make a mistake, here?

Markus