Re: [boost] Patch for type_traits

From: John Maddock (jm_at_[hidden])
Date: 2003-05-18 05:49:32

> This small patch removes all the warnings the type_traits regression suite
> is actually encountering with Intel compiler on Linux. And thanks to this
> patch, the number of warnings for the whole Boost regression suite on this
> particular compiler drops from 50 to 1.
>
> Index: libs/type_traits/test/test.hpp
> ===================================================================
> RCS file: /cvsroot/boost/boost/libs/type_traits/test/test.hpp,v
> retrieving revision 1.4
> diff -u -r1.4 test.hpp
> --- libs/type_traits/test/test.hpp      1 Feb 2003 12:12:08 -0000
1.4
> +++ libs/type_traits/test/test.hpp      18 May 2003 07:58:19 -0000
> @@ -126,7 +126,7 @@
>  # ifdef BOOST_MSVC
>  #  pragma warning(push)
>  #  pragma warning(disable: 4181)
> -# elif defined(__ICL)
> +# elif defined(__ICL) || defined(__ICC)
>  #  pragma warning(push)
>  #  pragma warning(disable: 21)
>  # endif
> @@ -141,7 +141,7 @@
>  typedef const r_type cr_type;
>  # ifdef BOOST_MSVC
>  #  pragma warning(pop)
> -# elif defined(__ICL)
> +# elif defined(__ICL) || defined(__ICC)
>  #  pragma warning(pop)
>  #  pragma warning(disable: 985) // identifier truncated in debug
information
>  # endif
>
> The patch is trivial: the original file removes the warning on Windows,
> this patch also removes them on Linux. I will apply the patch if nobody
> complains.
>
> But, more importantly, I want to use this mail to repeat my proposal of a
> BOOST_INTEL macro to encompass __INTEL_COMPILER, __ICL, __ICC, __ECC
> (thanks to Richard Hadsell for pointing it out) macros. I am not asking
> for somebody else to do it, I just want a bit of approval before preparing
> the patches since it is not a small job to add a new config macro.

Yes, please go ahead with that, it looks like a good idea,

thanks,

John.