[boost] Re: Inconsistency using BOOST_WORKAROUND in format library

From: David Abrahams (dave_at_[hidden])
Date: 2003-07-16 06:01:57

"Drazen DOTLIC" <Drazen.Dotlic_at_[hidden]> writes:

> Hello,
>
> There was a message few weeks ago that did not get satisfactory answer
> IMHO. It's about compiler workaround in boost/format/feed_args.hpp (note
> that we use VC7.1):
> [original]
>  #if BOOST_WORKAROUND( BOOST_MSVC, BOOST_TESTED_AT(1300))
> [fixed]
> #if BOOST_WORKAROUND( BOOST_MSVC, <= 1300)
>
> At the same time, in msvc_disambiguater.hpp:
> [working]
> #if defined(BOOST_MSVC) && BOOST_MSVC <= 1300 // this whole header is
> specifically for msvc
>
> The problem is that macro [working] is, well, working, but the
> [original] doesn't, and they should work together (by design) - again,
> all this with VC7.1. My proposal is that if we are all to use these
> macros, we should use them consistently, and if we do, I'd rather see
> the version marked as [fixed] above - it does the same thing (according
> to the docs) 

No it does *not*.  Please re-read the docs.

I have no opinion on which one is better for this case, but they are
different!

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com