Re: [boost] regex warnings

From: John Maddock (john_at_[hidden])
Date: 2003-10-21 06:24:33

> I received a few warning messages which may be of
> interest to the developers:

Thanks,

> C:\libSrc\boost\libs\regex\src\cpp_regex_traits.cpp(643):
> warning #186: pointless comparison of unsigned integer
> with zero
>            if((s[j] <= UCHAR_MAX) && (s[j] >= 0))
>                                            ^
>           detected during instantiation of class
> "boost::re_detail::message_data<wchar_t={unsigned
> short}>" at line 597

I don't think I can do much about that - the test is needed if wchar_t is
signed, and not if it's not :-(

> C:\libSrc\boost\libs\regex\src\cpp_regex_traits.cpp(665):
> warning #140: too many arguments in function call
>            while(*p1 && BOOST_REGEX_STD
> isspace((wchar_t)*p1, l))++p1;
>
>        ^

That's worrying - apart from anything else supplying too many arguments to a
function call should be an error - and in any case it's *not* supplying too
many arguments it's calling:

std::isspace(wchar_t, const std::locale&);

It would need some investigation on your part to figure out what the issue
is here.

Thanks,

John.