[boost] Re: regex warnings

From: David Abrahams (dave_at_[hidden])
Date: 2003-10-21 08:20:09

"John Maddock" <john_at_[hidden]> writes:

>> I received a few warning messages which may be of
>> interest to the developers:
>
> Thanks,
>
>> C:\libSrc\boost\libs\regex\src\cpp_regex_traits.cpp(643):
>> warning #186: pointless comparison of unsigned integer
>> with zero
>>            if((s[j] <= UCHAR_MAX) && (s[j] >= 0))
>>                                            ^
>>           detected during instantiation of class
>> "boost::re_detail::message_data<wchar_t={unsigned
>> short}>" at line 597
>
> I don't think I can do much about that - the test is needed if wchar_t is
> signed, and not if it's not :-(

I think it's not to hard to make an "is_non_negative" function which
returns true unconditionally for unsigned integral types.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com