Re: [boost] Re: FC++ Formal review is now in progress (2/13-2/23)

From: Brian McNamara (lorgon_at_[hidden])
Date: 2004-02-13 18:06:47

On Fri, Feb 13, 2004 at 10:53:54PM +0100, Giovanni Bajo wrote:
> > This library has been tested with icc7 and with gcc-3.1.1 (and various
> > other gcc-3.x.y versions) on Solaris and Linux.
> 
> I tried compilation with GCC 3.4.0. I found out the following:
> 
> [various compiler errors elided] 

Thanks much for this detailed report.  I have fixed things up according
to your notes; I am running some regression tests now, but will post an
updated copy to the web site so that others using this compiler version
won't encounter the same problems.  (If you happen to have time to
double-check my work after I post the update, please let me know the
results (off-list).)

> * rep_min has some problems, because it enters an infinite loop:

It's not infinite (redirect stdout to /dev/null to see), just output
placed (annoyingly) in a very long loop.

> * A few tests are interactive, I don't think this is correct. They should be
> either recategorized as examples, or modified to be fully automatic.
> 
> I should also notice that the zip file could be arranged already with
> the boost directory structure (boost/fc/* for includes, and
> libs/fc/{examples,tests}/* for the tests and examples). 

I haven't made any changes here (to keep things relatively "stable"
during the review period), but yes, noted.

Thanks,
   Brian

-- 
-Brian McNamara (lorgon_at_[hidden])