Re: [boost] Formal Review: Circular Buffer

From: Jan Gaspar (jano_gaspar_at_[hidden])
Date: 2004-03-08 13:03:25

--- Jeremy Siek <jsiek_at_[hidden]> wrote:
> I have read the documentation for the library, and
> browsed through the 
> test code.
> Based on that I recommend acceptance of the circular
> buffer library. 
> Nice work Jan!
> 
> Here are some suggestions.
> 
> This sentences seems unnecessary:
>      In fact the circular_buffer is defined in the
> file
>      boost/circular_buffer/base.hpp, but it is
> necessary to include the
>     boost/circular_buffer.hpp in order to use this
> container
> 
No it isn't, I'll change it.

> Have you checked whether CopyConstructible is in
> fact the only
> requirements needed on the type parameter T? For
> example, I bet
> T must also be Assignable. But who knows what other
> requirements you 
> may have
> missed (it is easy to miss them). I recommend using
> concept archetypes 
> to check this.
> 
Yes, it is the only requirement.

> There are no requirements on the Alloc type
> parameter. Surely there
> should be some.
> 
I think the Alloc has to be just an allocator (with
the neccessary methods). No special requirements
needed.

Jan

__________________________________
Do you Yahoo!?
Yahoo! Search - Find what you’re looking for faster
http://search.yahoo.com