Re: [boost] Re: [config] _WIN32 question

From: Vladimir Prus (ghost_at_[hidden])
Date: 2004-07-16 07:48:02

David Abrahams wrote:

> >    #elif defined(_WIN32) || defined(__WIN32__) || defined(WIN32)
> >    // win32:
> >    ....
> >
> > Does it mean I have to use the same conditional? Which compilers define
> > __WIN32__ or WIN32, but don't define _WIN32? Shouldn't there be a single
> > BOOST_WINDOWS macros to help in this cases?
>
> Yes and yes, IMO.

What about the attached patch, then?

> > # if !defined( BOOST_WINDOWS ) && !defined( BOOST_POSIX )
> > #   if defined(_WIN32) || defined(__WIN32__) || defined(WIN32)
> >
> >          || defined(__CYGWIN__)
> >
> > #     define BOOST_WINDOWS
> > #   else
> > #     define BOOST_POSIX
> > #   endif
> > # endif
>
> ...which is strange because Cygwin is a Posix platform.

Yea, strange. It's bad that cygwin is not in regression tests....

- Volodya