Re: [boost] Re: String Algo bug.

From: Pavol Droba (droba_at_[hidden])
Date: 2004-07-29 09:28:56

Hi,

On Mon, Jul 19, 2004 at 05:04:32PM +0200, Stefan Slapeta wrote:
> David Abrahams wrote:
> 
> >
> >No it does not, but it may cost you an extra bool in your iterator
> >class.
> >
> 
> Not necessary. Could anybody comment this fix (...and apply it if it's 
> ok)? Tests are fine.

This fix is correct. It is precisely what is equal ment to be. I have overlooked
the order of comparisons.

find_iterator can be in two states: 
1) Valid: all internal iterator variables point to valid iterators. Valid find
   iterators are equal if they point to the same part of the sequence.

2) Null: all null iterators are equal and at
         the end of sequence, the iterator automaticaly becames null.

> BTW, the replace test doesn't compile at all with VC7.1+STLPort. I'll 
> have a look on that later.
> 

I don't know what can be the problem. Can you elaborate a little more?

Thanks for the fix,

Regards,

Pavol