Re: [boost] Problem with code in common_factor_ct.hpp

From: Daryle Walker (darylew_at_[hidden])
Date: 2005-02-07 10:40:27

On 2/2/05 5:24 PM, "David Abrahams" <dave_at_[hidden]> wrote:

> Daryle Walker <darylew_at_[hidden]> writes:
> 
>> On 1/31/05 4:29 PM, "David Abrahams" <dave_at_[hidden]> wrote:
>> 
>>> "John H. Spicer" <jhs_at_[hidden]> writes:
>>> 
>>>> This file includes the code below in an #else for
>>>> BOOST_NO_TEMPLATE_PARTIAL_SPECIALIZATION.  We give an error on that code
>>>> because of a missing "template" keyword (between :: and helper).
>>>> 
>>>> What is the proper channel for reporting things like this?
>>> 
>>> http://www.boost.org/more/bugs.htm shows several alternatives.
>>> 
>>>> template < unsigned long Value2 >
>>>> struct helper
>>>> {
>>>>     BOOST_STATIC_CONSTANT( unsigned long, value
>>>>      = static_gcd_helper2_t<Value2>::helper<Value1 % Value2>::value );
>>>> };
>> 
>> Did you apply the change already, Dave?  (Assuming that it's the correct
>> action.)
> 
> Sorry, not my job (and it would be nice if you'd check the CVS
> yourself to find out, if you are the maintainer).  All I did was to
> forward the message here.

I would think that section 3.1 on that web page could apply.  Anyway, I
placed a change similar to ones already in that header file.

        template < unsigned long Value2 >
        struct helper
        {
            BOOST_STATIC_CONSTANT( unsigned long, value
             = static_gcd_helper2_t<Value2>::BOOST_NESTED_TEMPLATE
             helper<Value1 % Value2>::value );
        };

It's not tested, though.  (Do we still have compilers that have
BOOST_NO_TEMPLATE_PARTIAL_SPECIALIZATION #defined?)

-- 
Daryle Walker
Mac, Internet, and Video Game Junkie
darylew AT hotmail DOT com