Re: [boost] [shared_ptr] possible bug in sp_counted_base.hpp

From: Peter Dimov (pdimov_at_[hidden])
Date: 2005-04-11 20:15:28

Rene Rivera wrote:
> Rene Rivera wrote:
> [...]
>> Which when applied to the other functions, compiles without warnings.
>> And since all the tests pass, I checked in the changes to CVS.
>
> Also, I forgot to ask about something I noticed.. In
> sp_counted_base.hpp there is this sequence:
>
>
>     #elif defined( __GNUC__ ) && ( defined( __i386__ ) || defined(
> __x86_64__ ) )
>     # include <boost/detail/sp_counted_base_gcc_x86.hpp>
>
> ...and further along...
>
>     #elif defined( WIN32 ) || defined( _WIN32 ) || defined( __WIN32__
>     ) # include <boost/detail/sp_counted_base_w32.hpp>
>
>
> Question is.. Shouldn't we be using the Win32 implementation in the
> case of GCC on Windows, i.e. under MinGW?

No, because the Win32 implementation on non-MSVC/Intel makes indirect calls 
to the kernel Interlocked* functions. The g++ version is better.