[boost] Re: Formal Review: FOREACH macro

From: Russell Hind (rh_gmane_at_[hidden])
Date: 2005-04-27 01:52:21

Yes I think BOOST_FOREACH should definitely be accepted.

     *  What is your evaluation of the design?

Very easy to learn and use

     * What is your evaluation of the implementation?

Can't comment

     * What is your evaluation of the documentation?

Very good.  Straight to the point and shows you how to use library

     * What is your evaluation of the potential usefulness of the library?

Very useful.  There are some loops I've written recently that require to 
know where we are in the container so will still have to use iterators 
for that, but in all other cases, I much prefer to use BOOST_FOREACH

The only (slight) problem I can see over using iterators is that if you 
forget to declare the loop variable as a reference, then changing the 
value won't have any effect.  iterators don't have this problem.

     * Did you try to use the library?  With what compiler?  Did you 
have any problems?

Borland' bcc32 5.6.4.  It can't handle r-values so I guess it has 
compliance level 2, but I'd like to see it added to the portability page 
all the same.

     * How much effort did you put into your evaluation? A glance? A 
quick reading? In-depth study?

I've been using BOOST_FOREACH for a couple of months now.

     * Are you knowledgeable about the problem domain?

Only as a user.

Cheers

Russell