[boost] Re: [1.33] Program_options and Borland

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-05-17 05:43:46

John Maddock wrote:

> The following patches get Boost.Program Options compiling with Borland C++
> 5.6.4 (it's enough to fix the regex grep test program which was what I
> wanted).  Is it OK to apply these?  

Yes, please!

> I can't see how they would cause 
> problems with other compilers: in fact I'm not at all clear how "cmdline"
> was ever found without the qualifier on other compilers.

The 'basic_command_line_parser' class template is derived from
detail::cmdline, and so, I believe the 'cmdline' name should be injected in
the scope of 'basic_command_line_parser'. Since all uses are inside that
class, unqualified 'cmdline' works fine. 

> I haven't looked at the runtime test failures with this compiler yet (has
> anyone?),

I'll try to reproduce with my version of borland later this week. But IIRC,
previously tests uses to pass for me while failing on metacomm.

Thanks,
Volodya