Re: [boost] run_tests.sh portability fix

From: David Abrahams (dave_at_[hidden])
Date: 2005-09-21 18:10:03

Jonathan Wakely <cow_at_[hidden]> writes:

> (sorry for not putting a library name in the subject line, I'm not sure
> what to put for this)
>
> Hi,
>
> tools/regression/run_tests.sh uses the "export x=y" syntax, which is not
> supported by /bin/sh on Solaris9 (and probably other systems.)

That's a bash-ism, AFAIK.

> This means "sh run_tests.sh" or "chmod u+x run_tests.sh; ./run_tests.sh"
> won't work, you must use /usr/xpg4/bin/sh or another, better, sh.
>
> The attached patch fixes the problem, at only a slight readability cost.
> Is this OK to apply?

Please just do it!

It was wrong to begin with; you never need permission to fix something
completely broken.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com