Re: [boost] [boost.python] Wrong version check?

From: David Abrahams (dave_at_[hidden])
Date: 2005-12-05 00:07:51

Ben Artin <macdev_at_[hidden]> writes:

> I think that this particular nit is hardly worth the amount of discussion it's 
> generated

Exactly.

> which is why Daryle and I believe that the change should be made now to make 
> subsequent modifications easier. 

Do you have any idea what code you're asking to have changed?  Do you
realize that the code being argued over was never checked in?

The current test is (boost/python/detail/config.hpp):

  #  if !defined(_WIN32) && !defined(__CYGWIN__)                                  \
      && !defined(BOOST_PYTHON_USE_GCC_SYMBOL_VISIBILITY)                         \
      && BOOST_WORKAROUND(__GNUC__, >= 3) && (__GNUC_MINOR__ >=5 || __GNUC__ > 3)
  #    define BOOST_PYTHON_USE_GCC_SYMBOL_VISIBILITY 1
  #  endif 

Do you have a problem with that?

I can imagine that the following would be a very minor improvement,
but it hardly seems to be worth the bits we're spending on it.

  #  if !defined(_WIN32) && !defined(__CYGWIN__)                                  \
      && !defined(BOOST_PYTHON_USE_GCC_SYMBOL_VISIBILITY)                         \
      && (BOOST_WORKAROUND(__GNUC__, == 3) && __GNUC_MINOR__ >=5                  \
          || BOOST_WORKAROUND(__GNUC__, > 3))
  #    define BOOST_PYTHON_USE_GCC_SYMBOL_VISIBILITY 1
  #  endif 

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com