Re: [boost] [numeric cast] Borland 2006 patch

From: Fernando Cacciola (fernando_cacciola_at_[hidden])
Date: 2006-03-16 17:22:48

Hi Alisdair,

Sorry for the delay...

AlisdairM wrote:
> Workarounds for old compiler are still necessary, simple update of
> version check should suffice:
>
> cvs diff -u -wb -- boost\numeric\conversion\cast.hpp (in directory
> E:\sourceforge\devel\boost\)
> Index: boost/numeric/conversion/cast.hpp
> ===================================================================
> RCS file: /cvsroot/boost/boost/boost/numeric/conversion/cast.hpp,v
> retrieving revision 1.8
> diff -u -w -b -r1.8 cast.hpp
> --- boost/numeric/conversion/cast.hpp 27 Jun 2005 15:05:12 -0000 1.8
> +++ boost/numeric/conversion/cast.hpp 19 Feb 2006 12:19:22 -0000
> @@ -22,7 +22,7 @@
>
> #include <boost/detail/workaround.hpp>
>
> -#if BOOST_WORKAROUND(BOOST_MSVC, < 1300) ||
> BOOST_WORKAROUND(_BORLANDC_, == 0x564)
> +#if BOOST_WORKAROUND(BOOST_MSVC, < 1300) ||
> BOOST_WORKAROUND(_BORLANDC_, BOOST_TESTED_AT(0x581))
>
> #  include<boost/numeric/conversion/detail/old_numeric_cast.hpp>
>
>
> OK to commit?

I suppose so...
This particular problem was not all-borland specific but particular of bcc
5.6.4.
That is, the library works in 5.5.1 (If I recall the version number
correctly... it's been so long :)
In fact, the library was developed in that compiler, so the idea was that
only the user of the latest bcc (at the time) needed to switch back to the
old numeric cast.

More specifically, numeric_limits<> failed to provide compile time
constants in the new STL (it was ok when they used RW)

So, if that was just kept broken forever after 5.6.4; or the new numeric
cast fails for any other reason, go ahead and commit the fix.

Best

--
Fernando Cacciola
SciSoft
http://fcacciola.50webs.com/