Re: [boost] [review] promotion traits - review period extended untilApril 9.

From: Tobias Schwinger (tschwinger_at_[hidden])
Date: 2006-04-07 13:37:07

Paul A Bristow wrote:
> | - What is your evaluation of the documentation?
> 
> Definitions given may be adequate, but is MUST have some user-friendly
> guidance as to when it would be useful. Even the summary would be better
> than nothing!

I mentioned this concern to the author during pre-review inspection and didn't reject it because it's an add-on to an existing library.

> 
> Practical exampleS of use are ESSENTIAL.
>

... given that they are not too lengthy and fit into the overall documentation style of TypeTraits, IMO.

> 
> | - How much effort did you put into your evaluation?
> Fast-track interrupt handling only ;-)
> 

Thank you very much for the permissive setting of your interrupt mask, then 8-) !

> | Please always explicitly state in your review, whether you 
> | think the library should be accepted into Boost.
> Accept, subject to providing documentation.
> 

Noted.

Regards,
Tobias

(Review Manager)