Re: [boost] [property_tree review] Making the interface leaner, concretely...

From: Ivan Vecerina (ivec_at_[hidden])
Date: 2006-04-24 08:33:55

"Thorsten Ottosen" <thorsten.ottosen_at_[hidden]> wrote in message 
news:444CBDBF.9010807_at_dezide.com...
: Ivan Vecerina wrote:
: > "Thorsten Ottosen" <thorsten.ottosen_at_[hidden]> wrote in message
: > news:444CB0DC.3040501_at_dezide.com...
:
: > : > Is the performance of those libraries measurably hit?
: > :
: > : Yes (I havn't looked at how std::vector is used in ASIO, but I can't 
see
: > : how it could get around the problem).
: > :
: > : > If so, maybe you want a pod_vector, which will also benefit
: > : > from relying on realloc.  No big deal.
: > :
: > : It's not just for PODs.
: >
: > How would you fill a non-POD vector with uninitialized data ?
:
: If subsequent in-place construction fails, the memory needs to be
: removed again without calling constructors.

Wow. Well I think this would have opened a Pandora box,
but I don't think we need to discuss this any further.

: > : It remains to be seen how many user wishes that can be crammed
: > : into the interface in a reasonable manner.
: >
: > It is exactly my point:  I doubt that a sufficiently complete
: > and consensual value & object conversion interface can be
: > completed on time.
: > So my suggestion is to go ahead with what we have or can do now,
: > but make it a non-member interface to allow future evolution.
:
: I fail to see how really disallow future evolution to have members.

So once a better interface is found, we will add them as additional
member functions, and try to avoid name collisions and misuse ?
Or will we make that improved interface a non-member interface,
and say "well, we have a deprecated in-class interface, but
you really shouldn't use it" ?
Or will you go back and remove members that were once included ?

I fail to see why you reject the idea of  separation of concern ,
which is a fundamental design principle.
Besides that, the currently proposed value conversion interface
is neither necessary, nor sufficient -- as demonstrated in a
number of independent comments.  So absolutely wanting to inject
the current interface into the class "to help novices" sounds...
questionable.

Ivan
-- 
http://ivan.vecerina.com/contact/?subject=NG_POST <- email contact form