Re: [boost] Another proposal for Bimap and Boost.MultIndex

From: Thorsten Ottosen (thorsten.ottosen_at_[hidden])
Date: 2006-05-07 10:57:50

Hi Adrian,

Jeff Garland wrote:
> Adrián Etchevarne wrote:
> 
>>Hello boosters, 
>>
>>I am submitting a proposal to Summer of Code of Google, and I am asking for  
>>some opinions about it.
>>If you are intereste you can reach it at
>>
>>http://termovirtual.homeunix.org/~saknussemm/SoCGoogle.pdf
>>http://termovirtual.homeunix.org/~saknussemm/SoCGoogle.ps.gz
> 
> 
> Your URL isn't quite right -- it's missing an soc
> 
> http://termovirtual.homeunix.org/~saknussemm/soc/SoCGoogle.pdf

Here are some comments on the interface/paper.

- you call it bitmap<K,V> somewhere, should be bimap, I expect

- I would srongly consider making the interface a refinement of std::map 
to allow drop in-replacement, and to minimize surprises for people

- Letting operator[]() work with Key1 and Key2 seems like a bad thing: 
what if the types are the same? What if the types are implicitly 
convertible to eachother (seems error-prone).

- if possible, prerserve the semantics of std::map<K,V>::operator[]() 
and provide throwing behavior by an at() member.

- consider not having to/from, but to have

     find( const Key1& );
     find2nd( const Key2& );
     at( const Key& );
     at2nd( const Key& );
     ...

etc.

best regards

-Thorsten