Re: [boost] [mpl][patch] std::pair compatiblity

From: Tobias Schwinger (tschwinger_at_[hidden])
Date: 2006-05-16 10:01:20

David Abrahams wrote:
> Tobias Schwinger <tschwinger_at_[hidden]> writes:
> 
> 
>>WHAT:
>>=====
>>
>>The patch changes the internal pair concept, so STL pairs and Fusion
>>pairs also work as MPL pairs.
> 
> 
> Is a corresponding doc change needed?
> 

Yes, here is the doc patch (I just noticed these type members are in fact *not* unspecified).
I'm currently checking for further dependencies in other Boost libraries.

Regards,

Tobias

Index: libs/mpl/doc/src/refmanual/TrivialMetafunction.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/TrivialMetafunction.rst,v
retrieving revision 1.1
diff -u -r1.1 TrivialMetafunction.rst
--- libs/mpl/doc/src/refmanual/TrivialMetafunction.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/TrivialMetafunction.rst	16 May 2006 13:45:04 -0000
@@ -12,7 +12,7 @@
 metafunction's instance. By convention, all `trivial metafunctions`__ in MPL 
 are named after the members they provide assess to. For instance, a |Trivial
 Metafunction| named ``first`` reaches for the ``x``\ 's nested member 
-``::first``.
+``::first_type``.
 
 __ `Trivial Metafunctions Summary`_
 
Index: libs/mpl/doc/src/refmanual/map.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/map.rst,v
retrieving revision 1.1
diff -u -r1.1 map.rst
--- libs/mpl/doc/src/refmanual/map.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/map.rst	16 May 2006 13:50:17 -0000
@@ -80,9 +80,9 @@
 |    at<m,k>::type                      |                                                           |
 |    at<m,k,default>::type              |                                                           |
 +---------------------------------------+-----------------------------------------------------------+
-| ``key_type<m,x>::type``               | Identical to ``x::first``; see |Associative Sequence|.    |
+| ``key_type<m,x>::type``               | Identical to ``x::first_type``; see |Associative Sequence|.    |
 +---------------------------------------+-----------------------------------------------------------+
-| ``value_type<m,x>::type``             | Identical to ``x::second``; see |Associative Sequence|.   |
+| ``value_type<m,x>::type``             | Identical to ``x::second_type``; see |Associative Sequence|.   |
 +---------------------------------------+-----------------------------------------------------------+
 | ``insert<m,x>::type``                 | A new ``map`` equivalent to ``m`` except that             |
 |                                       | ::                                                        |
Index: libs/mpl/doc/src/refmanual/pair.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/pair.rst,v
retrieving revision 1.1
diff -u -r1.1 pair.rst
--- libs/mpl/doc/src/refmanual/pair.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/pair.rst	16 May 2006 13:49:48 -0000
@@ -15,8 +15,8 @@
     struct pair
     {
         typedef pair type;
-        typedef T1 first;
-        typedef T2 second;
+        typedef T1 first_type;
+        typedef T2 second_type;
     };
 
 
@@ -55,8 +55,8 @@
             >
         >::type p;
 
-    BOOST_MPL_ASSERT_RELATION( p::first::value, ==, 8 );
-    BOOST_MPL_ASSERT_RELATION( p::second::value, ==, 3 );
+    BOOST_MPL_ASSERT_RELATION( p::first_type::value, ==, 8 );
+    BOOST_MPL_ASSERT_RELATION( p::second_type::value, ==, 3 );
 
 
 See also
Index: libs/mpl/doc/src/refmanual/partition.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/partition.rst,v
retrieving revision 1.1
diff -u -r1.1 partition.rst
--- libs/mpl/doc/src/refmanual/partition.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/partition.rst	16 May 2006 13:48:48 -0000
@@ -103,8 +103,8 @@
         , back_inserter< vector<> >
         >::type r;
 
-    BOOST_MPL_ASSERT(( equal< r::first, vector_c<int,1,3,5,7,9> > ));
-    BOOST_MPL_ASSERT(( equal< r::second, vector_c<int,0,2,4,6,8> > ));
+    BOOST_MPL_ASSERT(( equal< r::first_type, vector_c<int,1,3,5,7,9> > ));
+    BOOST_MPL_ASSERT(( equal< r::second_type, vector_c<int,0,2,4,6,8> > ));
 
 
 See also
Index: libs/mpl/doc/src/refmanual/reverse_partition.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/reverse_partition.rst,v
retrieving revision 1.1
diff -u -r1.1 reverse_partition.rst
--- libs/mpl/doc/src/refmanual/reverse_partition.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/reverse_partition.rst	16 May 2006 13:48:30 -0000
@@ -103,8 +103,8 @@
         , back_inserter< vector<> >
         >::type r;
 
-    BOOST_MPL_ASSERT(( equal< r::first, vector_c<int,9,7,5,3,1> > ));
-    BOOST_MPL_ASSERT(( equal< r::second, vector_c<int,8,6,4,2,0> > ));
+    BOOST_MPL_ASSERT(( equal< r::first_type, vector_c<int,9,7,5,3,1> > ));
+    BOOST_MPL_ASSERT(( equal< r::second_type, vector_c<int,8,6,4,2,0> > ));
 
 
 See also
Index: libs/mpl/doc/src/refmanual/reverse_stable_partition.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/reverse_stable_partition.rst,v
retrieving revision 1.1
diff -u -r1.1 reverse_stable_partition.rst
--- libs/mpl/doc/src/refmanual/reverse_stable_partition.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/reverse_stable_partition.rst	16 May 2006 13:47:57 -0000
@@ -117,8 +117,8 @@
         , back_inserter< vector<> >
         >::type r;
 
-    BOOST_MPL_ASSERT(( equal< r::first, vector_c<int,9,7,5,3,1> > ));
-    BOOST_MPL_ASSERT(( equal< r::second, vector_c<int,8,6,4,2,0> > ));
+    BOOST_MPL_ASSERT(( equal< r::first_type, vector_c<int,9,7,5,3,1> > ));
+    BOOST_MPL_ASSERT(( equal< r::second_type, vector_c<int,8,6,4,2,0> > ));
 
 
 See also
Index: libs/mpl/doc/src/refmanual/reverse_unique.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/reverse_unique.rst,v
retrieving revision 1.1
diff -u -r1.1 reverse_unique.rst
--- libs/mpl/doc/src/refmanual/reverse_unique.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/reverse_unique.rst	16 May 2006 13:46:50 -0000
@@ -98,7 +98,7 @@
                 , identity< first<_1> >
                 , apply_wrap\ ``2``\<in_op, first<_1>, _2>
                 >
-            >::type::first r;
+            >::type::first_type r;
 
 
 Complexity
Index: libs/mpl/doc/src/refmanual/sort.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/sort.rst,v
retrieving revision 1.1
diff -u -r1.1 sort.rst
--- libs/mpl/doc/src/refmanual/sort.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/sort.rst	16 May 2006 13:46:31 -0000
@@ -95,8 +95,8 @@
             , aux_in
             >::type partitioned;
 
-        typedef sort<partitioned::first,p,aux_in >::type part1;
-        typedef sort<partitioned::second,p,aux_in >::type part2;
+        typedef sort<partitioned::first_type,p,aux_in >::type part1;
+        typedef sort<partitioned::second_type,p,aux_in >::type part2;
         
         typedef copy<
               joint_view< 
Index: libs/mpl/doc/src/refmanual/stable_partition.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/stable_partition.rst,v
retrieving revision 1.1
diff -u -r1.1 stable_partition.rst
--- libs/mpl/doc/src/refmanual/stable_partition.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/stable_partition.rst	16 May 2006 13:45:42 -0000
@@ -117,8 +117,8 @@
         , back_inserter< vector<> >
         >::type r;
 
-    BOOST_MPL_ASSERT(( equal< r::first, vector_c<int,1,3,5,7,9> > ));
-    BOOST_MPL_ASSERT(( equal< r::second, vector_c<int,0,2,4,6,8> > ));
+    BOOST_MPL_ASSERT(( equal< r::first_type, vector_c<int,1,3,5,7,9> > ));
+    BOOST_MPL_ASSERT(( equal< r::second_type, vector_c<int,0,2,4,6,8> > ));
 
 
 See also
Index: libs/mpl/doc/src/refmanual/unique.rst
===================================================================
RCS file: /cvsroot/boost/boost/libs/mpl/doc/src/refmanual/unique.rst,v
retrieving revision 1.1
diff -u -r1.1 unique.rst
--- libs/mpl/doc/src/refmanual/unique.rst	29 Nov 2004 06:33:06 -0000	1.1
+++ libs/mpl/doc/src/refmanual/unique.rst	16 May 2006 13:43:44 -0000
@@ -98,7 +98,7 @@
                 , identity< first<_1> >
                 , apply_wrap\ ``2``\<in_op, first<_1>, _2>
                 >
-            >::type::first r;
+            >::type::first_type r;
 
 
 Complexity