Re: [boost] Spurious warning in lexical_cast.hpp

From: Paul A Bristow (pbristow_at_[hidden])
Date: 2006-08-01 07:42:35

|  -----Original Message-----
|  From: boost-bounces_at_[hidden] 
|  [mailto:boost-bounces_at_[hidden]] On Behalf Of Gennaro Prota
|  Sent: 29 July 2006 18:23
|  To: boost_at_[hidden]
|  Subject: Re: [boost] Spurious warning in lexical_cast.hpp
|  
|  On Fri, 28 Jul 2006 19:29:34 -0400, "Joe Gottman"
|  <jgottman_at_[hidden]> wrote:
|  
|  > When I compile lexical_cast.hpp using MSVC 03 I get a 
|  spurious warning:
|  >
|  >  warning C4701: local variable 'result' may be used 
|  without having been initialized.
|  
|  The code can easily be rewritten in terms of nested if-s, with the
|  arguable benefit that a Target instance would be constructed only if
|  interpreter << arg succeeded. 

Agreed - and previously suggested to the author.

|Apart from that marginal gain, the point
| is whether we want to support the insane VC 7.1 warning level 4.

I am strongly in favour of supporting 8.0 warning level 4.

It provides ***some*** useful warnings, as well as some less helpful ones.

Code that is warning free is a higher quality even if the warnings are
supressed because it shows the issues have been considered.

Some groups enforce 'strict' warning level as a matter of policy and I think
Boost should respect this decision, even if considered insane by some.

Paul

---
Paul A Bristow
Prizet Farmhouse, Kendal, Cumbria UK LA8 8AB
[phone] & SMS, Mobile [phone] & SMS
pbristow_at_[hidden]