Re: [boost] [Review][bimap]

From: Thorsten Ottosen (thorsten.ottosen_at_[hidden])
Date: 2007-02-23 10:59:54

John Maddock wrote:
> Thorsten Ottosen wrote:
> 
>>Here's a list of things I feel strongly about changing (see below for 
>>info): 
>>
>>- relation should have the same members as std::pair
> 
> 
> Maybe, I quite like the systematic use of left and right personally.

Isn't the members required if we want to be signature compatible with
std containers? As it stands now, we are signature compatible for
a certain set f member functions, but not for iterators.

> 
>>- types should lie with members, so
>>
>>  map::left_type::iterator i = m.left.begin()
>>
>>instead of
>>
>>  map::left_iterator i = m.left.begin()
> 
> 
> Isn't that true now?  Or rather that both are possible currently?  
> 
> My only comment is that it's a lot easier to write:
> 
> typedef typename map::left_iterator it_type;
> 
> than:
> 
> typedef typename map::left_type left_type;
> typedef typename left_type::iterator it_type;
> 
> So I would go with both.

Perhaps that is ok.

-Thorsten