Re: [boost] Request for 1.34.1 milestone (bug #906)

From: Johan Nilsson (r.johan.nilsson_at_[hidden])
Date: 2007-05-22 08:09:05

Anthony Williams wrote:
> "Johan Nilsson" <r.johan.nilsson_at_[hidden]> writes:
>

[snip]

>
>> IIRC we earlier discussed checking for a valid TSS index before
>> calling TlsSetValue when in the cleanup_slots context.
>
> That was when you suggested calling TlsSetValue *after* cleanup slots
> --- at which point the TSS index may not be valid. In cleanup_slots
> (where it is now) it is always valid, so we don't need the check.

True.

[snip]

>> [A bit off-topic] Is it intentional to have the 1.34.1 updates go
>> under the RC_1_34_0 branch?
>
> Yes.

Isn't it a bit illogical to have 1.34.1 go under RC_1_34_0 (with emphasis on 
the trailing zero)?

>
> Attached is a revised patch.

Ok, applied and retested. Looks good.

FWIW, I vote to accept it.

Thanks / Johan