Re: [boost] a new release of the Join asynchronous concurrency library, please schedule a review

From: Yigong Liu (yigongliu_at_[hidden])
Date: 2007-07-19 12:34:40

Hello,

On 7/19/07, Mathias Gaunard <mathias.gaunard_at_[hidden]> wrote:
>
>
> There is a BOOST_STATIC_ASSERT

> You might want to directly look at the assembler output, it might simply
> have to do with some inlining that isn't done.

thanks for the suggestions .

I see that the string is taken by value in your small examples.
> Shouldn't it be taken by const-reference instead?
>
> Same for async_o etc.

Yes, in real application code, it should be reference. In Join, async /
synch methods take whatever signature users defined (similar to
Boost.Signals), users are expected to follow general rule when making normal
function calls, such as pass large data set thru pointers and references.
The Join library just let user define the signature as normal.

- why are you using boost.function? Aren't regular function objects enough?
> - how is concurrency handled? Locks? What kind? Is the scheduling fair?
>
> these are more involving. let me get back to it during night.

Thanks
Yigong