Boost logo

Boost :

From: Jens Seidel (jensseidel_at_[hidden])
Date: 2007-11-13 05:18:51


Hi John,

On Tue, Nov 13, 2007 at 11:06:29AM +0200, John Torjo wrote:
> Applied, thanks :)

please avoid top posting. You know why, right? (Otherwise search the
web for it.)

I have not yet ported my code to use the new logger version but I
nevertheless think the code compiles now clean on many systems. Great.

John, you should improve your commits and the SVN log messages a little
bit. If you recieve a patch you should e.g. commit it (more or less)
unchanged and mention the submitter even with email address. I do not
care about my stuff (it was too trivial and I expected that you clean
the patches first) but it is e.g. very important for copyright issues.
Once the code should be relicensed you have to contact all contributors
or rewrite contributed code from scratch.
So it would be also simpler to determine who introduced bugs ...

Currently I think you work locally with another version control system
or maybe even without to collect your stuff (which you call versions)
before you commit. Probably the commits are done automatically once you
start a special action? Please note that there is no need to set the date
in the svn log. It's the task of Subversion to handle it.
So I think it is OK to commit even smaller changes into repository,
that's why a repository exists beside source tar balls :-)

Thanks,
Jens


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk