Re: [boost] [review] Fast track formal review of Forward library begins today

From: Eric Niebler (eric_at_[hidden])
Date: 2007-12-03 14:52:17

John Torjo wrote:
> The formal review of the Boost.Functional/Forward library, proposed by 
> Tobias Schwinger, begins today :

<snip>

>      * What is your evaluation of the design?

Good. I can think of a couple of missing features.

- An option to handle const and non-const arguments up to N, and only 
[non-]const arguments from N to M.

- Automatically detect if the compiler supports variadic templates and 
rvalue references and use those instead. This can be a useful 
portability utility when such compilers become more common.

>      * What is your evaluation of the implementation?

Looks good, but it's hard to see thru the PP gunk. :-)

>      * What is your evaluation of the documentation?

Short and to the point. Would be nice if the reference section for each 
of the adaptors had a little example usage.

>      * What is your evaluation of the potential usefulness of the library?

Very useful.

>      * Did you try to use the library? With what compiler?
>        Did you have any problems?

No, but I used this feature when it was part of Fusion, and it was handy.

>      * How much effort did you put into your evaluation?

Not counting my previous experience with the Fusion function adaptors, 
about an hour with the docs and code.

>        A glance? A quick reading? In-depth study?
>      * Are you knowledgeable about the problem domain?
> 
> And finally, every review should answer this question:
> 
>      * Do you think the library should be accepted as a Boost library?
>        Be sure to say this explicitly so that your other comments
>        don't obscure your overall opinion.

Yes.

-- 
Eric Niebler
Boost Consulting
www.boost-consulting.com