Re: [boost] [swap] Renaming boost_swap_impl::swap_impl and/or its namespace?

From: David Abrahams (dave_at_[hidden])
Date: 2008-08-15 19:24:42

on Fri Aug 15 2008, Niels Dekker - mail address until 2008-12-31 <nd_mail_address_valid_until_2008-12-31-AT-xs4all.nl> wrote:

>> The name swap_using_adl, besides that not everyone knows
>> the acronym "adl", makes it less obvious whether it
>> can find the generic std::swap implementation
>> (through 'using' not ADL).
>
> Indeed, you're right. I was actually considering to spell it out:
> swap_using_argument_dependent_lookup(T&,T&). 

IMO, the person reading the code shouldn't be burdened with the
mechanical details (e.g. ADL) of how the function works.

> But do you have a better suggestion?  What about just renaming the
> function to "call_swap(T&,T&)"?  Because that's what it does: it just
> calls the most appropriate swap function.

Or, you might say that it "swaps" its arguments.  Hey, maybe we should
call it swap(T&,T&)!

> Anyway, its name is not that important, 

I think the name is important.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com