Re: [boost] [date_time] Patch for ticket #1740: date_time includes <windows.h>

Subject: Re: [boost] [date_time] Patch for ticket #1740: date_time includes <windows.h>
From: Kim Barrett (kab.conundrums_at_[hidden])
Date: 2008-10-14 12:35:59

At 8:42 AM -0700 10/14/08, Jeff Garland wrote:
>>>Just a technical comment on the suggested patch. Is it really wise 
>>>/ legal to
>>>replicate the Windows API declarations in Boost.
>>
>>Isn't that exactly what other libs such as WINE do? See
>>
>>http://source.winehq.org/source/include/
>
>Yeah, I guess they would have to since they are an emulation of the 
>Win32 api.  AFAIK we've never taken this approach in Boost so I 
>think we should talk thru if it's acceptable before putting it in. 
>If it is acceptable, I guess the other question might be if it 
>belongs in config instead of an individual library.

boost.thread already does this: see, for example, the #else clause of the
#if defined( BOOST_USE_WINDOWS_H ) block in trunk version of
boost/thread/win32/thread_primitives.hpp.

This approach has also been at least discussed for and possibly adopted by
asio, interprocess, and filesystem, all for the same reason that including
windows.h is considered pretty intrusive by some people.