Boost logo

Boost :

Subject: Re: [boost] [shared_ptr][repost] Ticket 2126 status?
From: Beman Dawes (bdawes_at_[hidden])
Date: 2008-10-20 08:30:03


On Sun, Oct 19, 2008 at 5:46 PM, Peter Dimov <pdimov_at_[hidden]> wrote:

> Andrey Semashev:
>
>> Sorry to reiterate, but I think this issue is rather critical and it
>> would be very nice to have it solved in the upcoming release.
>>
>> Peter, have you reviewed the patch I attached?
>>
>
> Yes, I have reviewed your patch.
>
> I don't want to merge the current shared_ptr, on which your patch depends.
> (Not at this time, at least). I also think that your patch stands to be
> improved a bit, but obviously, this is of secondary concern.
>
> (In addition, I prefer to add tests that identify the failure either
> before, or in concert with, commiting a fix.)
>
> If this issue is considered important enough to block the release, I'll see
> what I can do to unblock it.

AFAICS, it isn't a showstopper. I'd rather have you work on it as part of
your regular shared_ptr maintenance.

> But keep in mind that (a) make_shared is still undocumented

Given its advantages, I hope you can document make_shared soon:-)

Thanks,

--Beman


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk