Re: [boost] [Review] Polynomial library review begins today

Subject: Re: [boost] [Review] Polynomial library review begins today
From: Neal Becker (ndbecker2_at_[hidden])
Date: 2009-03-10 09:07:53

Looking briefly, I have 2 comments:

1) The first text is 'Background'.  We need some introduction here.  An 
overview of the purpose of the library.

2) """
Modification from std::vector: 
  polynomial<FieldType>& operator=(std::vector<FieldType>& c);

 This function uses the nested std::vector::swap() function. The c vector 
should contain new coefficients.
"""
  
Does this mean that the vector 'c' is modified?  I can't accept this.  This 
really violates the principle of least surprise.  Noone expects an operator= 
to act like that.