Re: [boost] [Review] Polynomial library review begins today

Subject: Re: [boost] [Review] Polynomial library review begins today
From: Peter Barker (newbarker_at_[hidden])
Date: 2009-03-12 08:55:39

I've not been able look at this much and will try to do better review
if time permits, but here's a very small piece of feedback:

https://svn.boost.org/svn/boost/sandbox/SOC/2008/polynomial/libs/docs/index.html
- typo "substraction" should be "subtraction".

https://svn.boost.org/svn/boost/sandbox/SOC/2008/polynomial/libs/docs/index.html
- typo "Greates Common" should be "Greatest Common".

This _extremely_ basic program failed to compile under MSVC 2003 SP1 (7.1):

#include <boost/polynomial.hpp>

int main()
{
}

with these errors:

c:\polynomial\boost\polynomial.hpp(109) : error C2783:
'boost::math::tools::polynomial<IntegerType>
boost::math::tools::gcd(boost::math::tools::polynomial<IntegerType>,boost::math::tools::polynomial<IntegerType>)'
: could not deduce template argument for 'IntegerType'
        c:\polynomial\boost\polynomial.hpp(33) : see declaration of
'boost::math::tools::gcd'
        c:\polynomial\boost\polynomial.hpp(248) : see reference to
class template instantiation
'boost::math::tools::polynomial<FieldType>' being compiled
c:\polynomial\boost\polynomial.hpp(109) : error C2063:
'boost::math::tools::gcd' : not a function

I am using Boost 1.38.0. It stopped me looking further at the library.
I'll try to get past this and continue if time permits...

Regards,

Peter Barker