Subject: Re: [boost] [serialization] BOOST_NO_EXCEPTIONS bug
From: Robert Ramey (ramey_at_[hidden])
Date: 2009-04-14 14:07:25
First of all, I should say I'm really embarassed to find such an
idiotic oversight on my part.
I've got no problem in seeing this checked into the trunk.
However, I don't think checking in a change directly into the
release branch is a great idea. This file is included by anything
in the library that throws an exception. Without comprehensive
testing, it's impossible to know that there will be no unexpected
repercussions. These repercussions could hold up the release
of ALL libraries for 1.39.
On the other hand, we know the repercussions
of letting this slide to the next release. One (very important) user
will have to patch his local copy until the next release.
I think the best is to check it into the trunk and let it
migrate into the release using the normal procedure.
Vladimir Prus wrote:
>> KDE folks has reported that trying to use Boost with exceptions
>> turned off results in duplicate symbol error from
>> like so:
>> kdevclassbrowser. dir/allclassesfolder.o: In function
>> `boost::serialization::throw_exception(std::exception const&)':
>> /usr/include/boost/serialization/throw_exception.hpp:29: multiple
>> definition of `boost::serialization::throw_exception(std::exception
>> The reason is missing inline, which the attached patch fixes?
>> Robert, is this OK for trunk & release branches?
>> - Volodya
>> Unsubscribe & other changes:
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk