Subject: Re: [boost] [serialization] BOOST_NO_EXCEPTIONS bug
From: Robert Ramey (ramey_at_[hidden])
Date: 2009-04-14 15:44:19
commit to the turnk.
Vladimir Prus wrote:
> Robert Ramey wrote:
>> First of all, I should say I'm really embarassed to find such an
>> idiotic oversight on my part.
>> I've got no problem in seeing this checked into the trunk.
>> However, I don't think checking in a change directly into the
>> release branch is a great idea. This file is included by anything
>> in the library that throws an exception. Without comprehensive
>> testing, it's impossible to know that there will be no unexpected
>> repercussions. These repercussions could hold up the release
>> of ALL libraries for 1.39.
> I don't think this is likely -- given that no tests are run with
> BOOST_NO_EXCEPTIONS defined, so even if some compilers, upon
> seeing the "inline" keyword, immediately die, this won't cause
> regression tests on release branch to die.
>> On the other hand, we know the repercussions
>> of letting this slide to the next release. One (very important) user
>> will have to patch his local copy until the next release.
>> I think the best is to check it into the trunk and let it
>> migrate into the release using the normal procedure.
> You mean, after seeing that nothing breaks? The release branch is open
> until 20th, so we have the time. Should I commit to trunk?
> - Volodya
> Unsubscribe & other changes: