[boost] [candidate bloom_filter] nitpick

Subject: [boost] [candidate bloom_filter] nitpick
From: JOAQUIN M. LOPEZ MUÑOZ (joaquin_at_[hidden])
Date: 2009-06-10 13:16:50

Hi Michael,

I see that internals.hpp declares the following:

namespace boost {
namespace detail {
template <class Input, class BitSet>
class bloom_filter_internals {...};
}
}

boost::detail should not be used for internals of a

specific library. The custom is to do it like this:

namespace boost{

namespace bloom_filters{

namespace detail{

// you might want to rename to just "internals"

// as the qualified name is sufficiently informative

template <class Input, class BitSet>
class bloom_filter_internals {...}; }

}

}

Note the "s" in "bloom_filters", following the naming guidelines at:

http://www.boost.org/development/requirements.html#Naming_consistency

Joaquín M López Muñoz

Telefónica, Investigación y Desarrollo